Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not handle paths with "@" in filename #30

Closed
davidgorges opened this issue May 7, 2015 · 2 comments
Closed

Does not handle paths with "@" in filename #30

davidgorges opened this issue May 7, 2015 · 2 comments

Comments

@davidgorges
Copy link

Does not work if the filename contains "@" - which is often the case for retina size images.

Input:

../images/logo@2x.png

Pickable:

2x.png

Expected:

../images/logo@2x.png
@groomsy
Copy link
Contributor

groomsy commented May 7, 2015

Ditto for filenames containing '+' (Objective-C categories anyone?).

@pcottle pcottle closed this as completed in af3db8a May 8, 2015
@pcottle
Copy link
Contributor

pcottle commented May 8, 2015

Thanks for the file @davidgorges ! I just pushed a fix now with some test coverage, this will make it into the next release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@groomsy @pcottle @davidgorges