Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary command mode doesn't have aliases or shell functions #32

Closed
seanabraham opened this issue May 7, 2015 · 2 comments
Closed

Comments

@seanabraham
Copy link

When executing a command in arbitrary command mode, fpp is unaware of any aliases or shell functions I may have defined in my .zshrc (I'm using zsh but I've tested this in bash as well).

For example I have an alias gco="git checkout"and running gco in the arbitrary command mode gives:

.fbPager.sh: line 4: gco: command not found

@pcottle
Copy link
Contributor

pcottle commented May 7, 2015

Yeah @SeanA208 we actually dont get any of the aliases that are already loaded in the shell script since we execute in another shell environment :_( So for bash we have to _manually* expand the aliases:

https://github.com/facebook/PathPicker/blob/master/src/output.py#L55

However no reason why we can't make a fallback...

@pcottle pcottle closed this as completed in e060419 May 7, 2015
@pcottle
Copy link
Contributor

pcottle commented May 7, 2015

Alright this is a bit hacky but e060419 should work. Can you try that? I don't have zsh installed unfortunately :-/

(obviously this isnt reflected in prod so youll have to make those changes manually to your brew installation)

thanks @SeanA208 for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants