Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo videos in homepage not loading on mobile #407

Open
code-reaper08 opened this issue Jul 23, 2021 · 2 comments
Open

Demo videos in homepage not loading on mobile #407

code-reaper08 opened this issue Jul 23, 2021 · 2 comments

Comments

@code-reaper08
Copy link
Contributor

code-reaper08 commented Jul 23, 2021

Describe the bug
Demo videos in homepage are not visible and leave a blank space in mobile browsers.
To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://facebook.github.io/PathPicker/' using mobile.
  2. Videos there don't display and leaves a space.

Expected behavior
The demo videos could have a fallback on mobile browsers, which makes them an image redirecting to the actual video demo.

Screenshots
in mobile browser
demo_video_missing
in desktop browser
demo_video_present

Desktop:

  • OS: Windows 10 pro
  • Browser: chrome Version 92.0.4515.107 (Official Build) (64-bit), firefox 90.0.2 (64-bit)

Smartphone:

  • Browser: chrome, firefox

Additional context
I am working on this issue currently and would make a PR in a couple of days. if you don't mind please assign this to me.
Thanks in advance 😄

@KapJI
Copy link
Member

KapJI commented Jul 24, 2021

I checked it in Safari on iPhone and there it works fine. Probably only Android is affected?

@code-reaper08
Copy link
Contributor Author

code-reaper08 commented Jul 24, 2021

I checked it in Safari on iPhone and there it works fine. Probably only Android is affected?

Thanks for your reply @KapJI
Most probably YES if it works on Safari,
Only android is affected. Is there anything we can do?

BTW I am not sure what causes this issue 😕

Tried implementing a fallback for mobile devices to make the video as an image, sadly that too is not rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants