Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpp not opening files in $EDITOR #420

Closed
Zane- opened this issue Apr 16, 2022 · 7 comments
Closed

fpp not opening files in $EDITOR #420

Zane- opened this issue Apr 16, 2022 · 7 comments

Comments

@Zane-
Copy link

Zane- commented Apr 16, 2022

Hello,

I have my $EDITOR set to vim, however when I attempt to open a file using fpp, it opens in nano instead.

Here's a video reproduction:
https://user-images.githubusercontent.com/6345012/163692696-1ca19d72-12a6-47b9-b565-ca8d6cf4e805.mp4

@Zane-
Copy link
Author

Zane- commented Apr 20, 2022

Thought it might be using $VISUAL, which was set to nano, but I've changed that to vim as well, and still opening in nano.

@Deckluhm
Copy link

Deckluhm commented May 3, 2022

If you didn't already read that, maybe that can help:

The $FPP_EDITOR environment variable can be set to tell PathPicker which editor to open the selected files with. If that variable is not set, $VISUAL and then $EDITOR are used as fallbacks, with "vim" as a last resort.

Also, be sure to restart your terminal after updating an environment variable.

@Zane-
Copy link
Author

Zane- commented May 3, 2022

I set that variable, and it works now, but I'll still keep this open as it didn't pick any of the fallbacks, nor the last resort.

@Deckluhm
Copy link

Deckluhm commented May 4, 2022

Are you sure $FPP_EDITOR wasn't already defined elsewhere? (maybe not by you but by a plugin or something like that)

@Zane-
Copy link
Author

Zane- commented May 4, 2022

I ripgrep'd my whole system, no results. I'm using a tmux-fpp plugin, but it doesn't set it anywhere (and I was also able to reproduce this outside of tmux)

I removed $FPP_EDITOR from my .zshrc, re-sourced it, and ran echo $FPP_EDITOR, which didn't return anything.

@Deckluhm
Copy link

Deckluhm commented May 4, 2022

tmux-plugins/tmux-fpp#18

It doesn't seem to be an issue with PathPicker but rather with tmux (and how it handles environment variables).

@Zane-
Copy link
Author

Zane- commented May 4, 2022

Works now that I've moved the EXPORT statements above tmux's execution in my .zshrc. Thanks!

@Zane- Zane- closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants