New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying command as an argument to fpp #72
Comments
Hrm I'm not sure of the benefits here -- you'll have to type how would this help your workflow @xatnys ? |
Indeed, this is more convenience / desired workflow than an outright improvement. There's a simplicity to splitting the workflow into two steps; something like this:
So, at least to me, it seems like it'd be more natural to fit in applying commands in the first step rather than after the file selection process. I'm not sure what the alias support specifically entails, but I suppose I'm looking to be able to create some specialized fpp aliases. I can hack around it by abusing $EDITOR so this is certainly not imperative. I'm currently doing this: |
Ahh hrmmm, yeah this is fairly legitimate. Let me keep this open for now, I do agree adding a bunch of aliases would be nice. Also keep in mind that we have |
@pcottle having this feature will also greatly help people who want to write scripts which use fpp. An example would be a script which downloads a set of zip files into a folder |
Ooooh that's a pretty sweet workflow @webglider, never thought about Alright you guys convinced me, ill add this right after I merge some of this UI testing work |
I have a PR half in flight on this one if you haven't started yet @pcottle which i was gonna try and finish tonight |
Alright go for it @lastquestion ! It might require some rebasing after I land some of the testing infra but we can see what it looks like when yours goes up :D |
did you decide on a testing infra? prob unittest because it's built into python and wouldn't require a dependecy? |
Oh yeah @lastquestion I meant the dependency injection we have to do in order to test the curses UI. Its not really "infra" or a dependency but a fair refactor of the UI code. However I got it working in 7753a73 Basically then
|
oic that's good approach. the mock is nice, also would be super sweet to have a built in logging to stderr or whatever that we can use while dev. I use sys.stderr.write and then remove it when i commit, but a general purpose logger would be useful |
if we are gonna stick with |
yeah we dont have general purpose logging, but you might also want to look at |
Fixed in #99 |
yeah i think this should work! #99 and my followups got the majority of it, but I do think we should prevent command mode if you have a preset command... |
Stay off my account On Wednesday, May 13, 2015, Lin Xu notifications@github.com wrote:
|
Would this be possible? Something like:
git status | fpp -c 'git add'
So that the default action is overridden and I can just hit 'enter' after selecting files to run
git add
on them.The text was updated successfully, but these errors were encountered: