Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more failure info to QueryCompletionEvent #3178

Closed
electrum opened this issue Jun 25, 2015 · 1 comment
Closed

Add more failure info to QueryCompletionEvent #3178

electrum opened this issue Jun 25, 2015 · 1 comment
Labels
beginner-task enhancement

Comments

@electrum
Copy link
Contributor

We need to know the task ID and the machine on which the failure occurred. This helps with finding logs related to a failure, correlating machines with higher than average failure counts, etc.
@monkey-mas
Copy link
Contributor

Let me try this one.

@electrum
Can you be more specific about machine information? I'm not sure what kind of information you have in mind. If you referred to nodeInstanceId[1] in TaskInfo as machine, it should be easy to add it to QueryCompletionEvent.

[1] https://github.com/facebook/presto/blob/c244ebaa629638fc0035f38ddc1c07948dba5100/presto-main/src/main/java/com/facebook/presto/execution/TaskInfo.java#L54

@cberner cberner closed this as completed Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-task enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@electrum @martint @cberner @monkey-mas