NPE with IN (null, ...) predicate for varchar columns

[martint]

This query:

SELECT count(*) FROM (values 'a') t(a) WHERE a in (null)

Fails with:

java.lang.NullPointerException: value is null
    at java.util.Objects.requireNonNull(Objects.java:228)
    at com.facebook.presto.spi.predicate.NullableValue.of(NullableValue.java:44)
    at com.facebook.presto.sql.planner.DomainTranslator$Visitor.visitComparisonExpression(DomainTranslator.java:365)
    at com.facebook.presto.sql.planner.DomainTranslator$Visitor.visitComparisonExpression(DomainTranslator.java:231)
    at com.facebook.presto.sql.tree.ComparisonExpression.accept(ComparisonExpression.java:91)
    at com.facebook.presto.sql.tree.AstVisitor.process(AstVisitor.java:22)
    at com.facebook.presto.sql.planner.DomainTranslator$Visitor.visitInPredicate(DomainTranslator.java:464)
    at com.facebook.presto.sql.planner.DomainTranslator$Visitor.visitInPredicate(DomainTranslator.java:231)
    at com.facebook.presto.sql.tree.InPredicate.accept(InPredicate.java:55)
    at com.facebook.presto.sql.tree.AstVisitor.process(AstVisitor.java:22)
    at com.facebook.presto.sql.planner.DomainTranslator.fromPredicate(DomainTranslator.java:228)
    at com.facebook.presto.sql.planner.optimizations.WindowFilterPushDown$Rewriter.visitFilter(WindowFilterPushDown.java:149)
    at com.facebook.presto.sql.planner.optimizations.WindowFilterPushDown$Rewriter.visitFilter(WindowFilterPushDown.java:82)
    at com.facebook.presto.sql.planner.plan.FilterNode.accept(FilterNode.java:71)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext.rewrite(SimplePlanRewriter.java:86)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext.lambda$defaultRewrite$145(SimplePlanRewriter.java:75)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext$$Lambda$298/694797030.apply(Unknown Source)
    at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
    at java.util.Iterator.forEachRemaining(Iterator.java:116)
    at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:502)
    at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext.defaultRewrite(SimplePlanRewriter.java:76)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter.visitPlan(SimplePlanRewriter.java:40)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter.visitPlan(SimplePlanRewriter.java:24)
    at com.facebook.presto.sql.planner.plan.PlanVisitor.visitAggregation(PlanVisitor.java:30)
    at com.facebook.presto.sql.planner.plan.AggregationNode.accept(AggregationNode.java:180)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext.rewrite(SimplePlanRewriter.java:86)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext.lambda$defaultRewrite$145(SimplePlanRewriter.java:75)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext$$Lambda$298/694797030.apply(Unknown Source)
    at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
    at java.util.Iterator.forEachRemaining(Iterator.java:116)
    at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:502)
    at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter$RewriteContext.defaultRewrite(SimplePlanRewriter.java:76)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter.visitPlan(SimplePlanRewriter.java:40)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter.visitPlan(SimplePlanRewriter.java:24)
    at com.facebook.presto.sql.planner.plan.PlanVisitor.visitOutput(PlanVisitor.java:50)
    at com.facebook.presto.sql.planner.plan.OutputNode.accept(OutputNode.java:81)
    at com.facebook.presto.sql.planner.plan.SimplePlanRewriter.rewriteWith(SimplePlanRewriter.java:34)
    at com.facebook.presto.sql.planner.optimizations.WindowFilterPushDown.optimize(WindowFilterPushDown.java:79)
    at com.facebook.presto.sql.planner.LogicalPlanner.plan(LogicalPlanner.java:103)
    at com.facebook.presto.execution.SqlQueryExecution.doAnalyzeQuery(SqlQueryExecution.java:265)
    at com.facebook.presto.execution.SqlQueryExecution.analyzeQuery(SqlQueryExecution.java:244)
    at com.facebook.presto.execution.SqlQueryExecution.start(SqlQueryExecution.java:208)
    at com.facebook.presto.execution.QueuedExecution.lambda$start$229(QueuedExecution.java:68)
    at com.facebook.presto.execution.QueuedExecution$$Lambda$260/1982974131.run(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

This is a regression in trunk.