[cassandra] Bump to current stable version. #1694

brndnmtthws · 2014-09-19T16:22:02Z

The 2.0.0-rc2 driver has a bug
(https://datastax-oss.atlassian.net/browse/JAVA-254) which gets
triggered when querying through presto.

The exception occurs because the driver attempts to query a table that
no longer exists, and fails.

Cassandra 2.1.0 is the current stable release, so it's probably time to
catch up.

The full exception looks like this:

Query 20140919_144621_02958_k67kx failed: replicate_on_write is not a column defined in this metadata
java.lang.IllegalArgumentException: replicate_on_write is not a column defined in this metadata
    at com.datastax.driver.core.ColumnDefinitions.getAllIdx(ColumnDefinitions.java:273)
    at com.datastax.driver.core.ColumnDefinitions.getFirstIdx(ColumnDefinitions.java:279)
    at com.datastax.driver.core.Row.getBool(Row.java:117)
    at com.datastax.driver.core.TableMetadata$Options.<init>(TableMetadata.java:474)
    at com.datastax.driver.core.TableMetadata.build(TableMetadata.java:107)
    at com.datastax.driver.core.Metadata.buildTableMetadata(Metadata.java:128)
    at com.datastax.driver.core.Metadata.rebuildSchema(Metadata.java:89)
    at com.datastax.driver.core.ControlConnection.refreshSchema(ControlConnection.java:259)
    at com.datastax.driver.core.ControlConnection.tryConnect(ControlConnection.java:214)
    at com.datastax.driver.core.ControlConnection.reconnectInternal(ControlConnection.java:161)
    at com.datastax.driver.core.ControlConnection.connect(ControlConnection.java:77)
    at com.datastax.driver.core.Cluster$Manager.init(Cluster.java:890)
    at com.datastax.driver.core.Cluster$Manager.newSession(Cluster.java:910)
    at com.datastax.driver.core.Cluster$Manager.access$200(Cluster.java:806)
    at com.datastax.driver.core.Cluster.connect(Cluster.java:158)
    at com.facebook.presto.cassandra.CassandraSession$1.load(CassandraSession.java:95)
    at com.facebook.presto.cassandra.CassandraSession$1.load(CassandraSession.java:90)
    at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3524)
    at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2317)
    at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2280)
    at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2195)
    at com.google.common.cache.LocalCache.get(LocalCache.java:3934)
    at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3938)
    at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4821)
    at com.facebook.presto.cassandra.CassandraSession.getSession(CassandraSession.java:115)
    at com.facebook.presto.cassandra.CassandraSession.executeWithSession(CassandraSession.java:435)
    at com.facebook.presto.cassandra.CassandraSession.executeQuery(CassandraSession.java:124)
    at com.facebook.presto.cassandra.CassandraRecordCursor.<init>(CassandraRecordCursor.java:42)
    at com.facebook.presto.cassandra.CassandraRecordSet.cursor(CassandraRecordSet.java:55)
    at com.facebook.presto.operator.RecordProjectOperator.<init>(RecordProjectOperator.java:45)
    at com.facebook.presto.split.RecordSetDataStreamProvider.createNewDataStream(RecordSetDataStreamProvider.java:40)
    at com.facebook.presto.split.DataStreamManager.createNewDataStream(DataStreamManager.java:58)
    at com.facebook.presto.operator.AbstractScanFilterAndProjectOperator.addSplit(AbstractScanFilterAndProjectOperator.java:95)
    at com.facebook.presto.operator.Driver.processNewSource(Driver.java:251)
    at com.facebook.presto.operator.Driver.processNewSources(Driver.java:216)
    at com.facebook.presto.operator.Driver.access$300(Driver.java:52)
    at com.facebook.presto.operator.Driver$DriverLockResult.close(Driver.java:491)
    at com.facebook.presto.operator.Driver.updateSource(Driver.java:194)
    at com.facebook.presto.execution.SqlTaskExecution$DriverSplitRunnerFactory.createDriver(SqlTaskExecution.java:585)
    at com.facebook.presto.execution.SqlTaskExecution$DriverSplitRunnerFactory.access$1700(SqlTaskExecution.java:552)
    at com.facebook.presto.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:673)
    at com.facebook.presto.execution.TaskExecutor$PrioritizedSplitRunner.process(TaskExecutor.java:444)
    at com.facebook.presto.execution.TaskExecutor$Runner.run(TaskExecutor.java:578)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)

facebook-github-bot · 2014-09-19T16:23:24Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot · 2014-09-19T16:34:48Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

brndnmtthws · 2014-09-19T17:24:53Z

There's a bug in one of the tests, so this is not ready to ship yet. I'll update the PR when it is.

brndnmtthws · 2014-09-20T02:04:56Z

Build passes now: https://gist.github.com/brndnmtthws/6274dc05d938c4abe9b6

I needed to remove the hector library, because it wasn't working as expected.

brndnmtthws · 2014-09-24T14:13:14Z

Looks like there was a build regression due to ed81faa. I've updated the code accordingly.

brndnmtthws · 2014-10-02T20:24:17Z

Rebased again on master to un-break the breakage (from 26b4c2a and 6acb314), and verified that the tests still pass.

victorpoluceno · 2014-10-03T18:43:06Z

👍

brndnmtthws · 2014-10-07T22:41:58Z

Looks like this regressed again due to changes elsewhere.

Rebased on master, and fixed the small stuff.

This reverts commit 60ff28d.

brndnmtthws · 2014-10-18T16:34:02Z

The changes from 60ff28d completely broke this PR, so I reverted that commit, reapplied the patch, and then implemented the same thing again.

brndnmtthws · 2014-10-18T16:37:09Z

Tests pass locally.

The 2.0.0-rc2 driver has a bug (https://datastax-oss.atlassian.net/browse/JAVA-254) which gets triggered when querying through presto. An exception occurs because the driver attempts to query a table that no longer exists, and fails. Cassandra 2.1.0 is the current stable release, so it's probably time to catch up. The hector library has been removed and replaced, because it didn't seem to work correctly with C* 2.1, and the project doesn't appear to be very active.

This is a redo of 60ff28d, minus the breakage.

brndnmtthws · 2014-10-18T17:59:14Z

Updated as per @martint's comments.

martint · 2014-10-18T20:22:39Z

I'm seeing the following error when running the full test suite:

2014-10-19 02:01:17 WARNING An exception was thrown by a user handler while handling an exception event ([id: 0xed24c1c4, /127.0.0.1:63353 => localhost/127.0.0.1:9142] EXCEPTION: java.lang.OutOfMemoryError: unable to create new native thread)
java.lang.OutOfMemoryError: unable to create new native thread
    at java.lang.Thread.start0(Native Method)
    at java.lang.Thread.start(Thread.java:714)
    at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:949)
    at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1360)
    at com.google.common.util.concurrent.MoreExecutors$ListeningDecorator.execute(MoreExecutors.java:484)
    at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:110)
    at com.google.common.util.concurrent.AbstractListeningExecutorService.submit(AbstractListeningExecutorService.java:50)
    at com.datastax.driver.core.Cluster$Manager.onSuspected(Cluster.java:1420)
    at com.datastax.driver.core.Cluster$Manager.signalConnectionFailure(Cluster.java:1670)
    at com.datastax.driver.core.Connection.defunct(Connection.java:265)
    at com.datastax.driver.core.Connection$Dispatcher.exceptionCaught(Connection.java:675)
    at org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstream(OneToOneDecoder.java:60)
    at org.jboss.netty.handler.codec.frame.FrameDecoder.exceptionCaught(FrameDecoder.java:377)
    at org.jboss.netty.channel.Channels.fireExceptionCaught(Channels.java:525)
    at org.jboss.netty.channel.AbstractChannelSink.exceptionCaught(AbstractChannelSink.java:48)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
    at org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstream(OneToOneDecoder.java:70)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
    at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462)
    at org.jboss.netty.handler.codec.frame.FrameDecoder.callDecode(FrameDecoder.java:443)
    at org.jboss.netty.handler.codec.frame.FrameDecoder.messageReceived(FrameDecoder.java:303)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
    at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
    at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:109)
    at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:312)
    at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:90)
    at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)

Can you try running mvn install -pl presto-cassandra -P ci on your end and see if it reproduces?

brndnmtthws · 2014-10-18T20:43:45Z

It did indeed fail with java.lang.OutOfMemoryError when I ran that. What's more interesting, is that when I increased the heap size to 3g, it failed with this: https://gist.github.com/brndnmtthws/a1d645280943a7f2a861

This seems to only occur after many iterations. I was only able to induce it once.

csarcom · 2014-10-29T14:31:16Z

https://gist.github.com/csarcom/9d62deca83024ff330ae

I got this Exception on launcher start.

I tried to build bump-cassandra-driver branch too and I got a different Exeception:

https://gist.github.com/csarcom/ce94184d9fec7691fdda

Any idea?

brndnmtthws · 2014-10-29T14:34:10Z

Hmm, that's really odd. I'm not sure what that's about. I'll take a look later today when I get a chance.

martint · 2014-10-29T15:26:05Z

I merged this with a few minor adjustments: f198d63

We can troubleshoot the out-of-memory error later.

brndnmtthws force-pushed the bump-cassandra-driver branch from bb5d39c to b16e82a Compare September 19, 2014 16:33

brndnmtthws force-pushed the bump-cassandra-driver branch 3 times, most recently from cb479d3 to ddb6efb Compare September 19, 2014 17:07

brndnmtthws force-pushed the bump-cassandra-driver branch 7 times, most recently from 1964dcb to eaffc50 Compare September 20, 2014 02:04

brndnmtthws force-pushed the bump-cassandra-driver branch from eaffc50 to 585846f Compare September 20, 2014 02:14

dain self-assigned this Sep 20, 2014

brndnmtthws force-pushed the bump-cassandra-driver branch 6 times, most recently from 2a23dd1 to 2b75404 Compare September 24, 2014 14:12

brndnmtthws force-pushed the bump-cassandra-driver branch 6 times, most recently from abedd84 to 191f6ae Compare September 24, 2014 19:33

brndnmtthws force-pushed the bump-cassandra-driver branch from 191f6ae to defca2d Compare October 2, 2014 20:23

brndnmtthws force-pushed the bump-cassandra-driver branch from defca2d to 356dce5 Compare October 7, 2014 22:41

brndnmtthws force-pushed the bump-cassandra-driver branch 2 times, most recently from e7ab401 to 0e024fe Compare October 10, 2014 17:21

Revert "Move static methods to a separate class"

e20bd81

This reverts commit 60ff28d.

brndnmtthws force-pushed the bump-cassandra-driver branch from 0e024fe to 23bbddf Compare October 18, 2014 16:23

brndnmtthws force-pushed the bump-cassandra-driver branch from 6bf62a0 to 779ac16 Compare October 18, 2014 17:22

brndnmtthws force-pushed the bump-cassandra-driver branch 2 times, most recently from e6f3dd7 to 3cc0a36 Compare October 18, 2014 17:57

[cassandra] Move static methods to separate class.

2a6592e

This is a redo of 60ff28d, minus the breakage.

brndnmtthws force-pushed the bump-cassandra-driver branch from 3cc0a36 to 2a6592e Compare October 18, 2014 17:58

martint closed this Oct 29, 2014

simonmorley mentioned this pull request Nov 5, 2014

Presto 0.8 with Cassandra 2.1.1 #1895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cassandra] Bump to current stable version. #1694

[cassandra] Bump to current stable version. #1694

brndnmtthws commented Sep 19, 2014

facebook-github-bot commented Sep 19, 2014

facebook-github-bot commented Sep 19, 2014

brndnmtthws commented Sep 19, 2014

brndnmtthws commented Sep 20, 2014

brndnmtthws commented Sep 24, 2014

brndnmtthws commented Oct 2, 2014

victorpoluceno commented Oct 3, 2014

brndnmtthws commented Oct 7, 2014

brndnmtthws commented Oct 18, 2014

brndnmtthws commented Oct 18, 2014

brndnmtthws commented Oct 18, 2014

martint commented Oct 18, 2014

brndnmtthws commented Oct 18, 2014

csarcom commented Oct 29, 2014

brndnmtthws commented Oct 29, 2014

martint commented Oct 29, 2014

[cassandra] Bump to current stable version. #1694

[cassandra] Bump to current stable version. #1694

Conversation

brndnmtthws commented Sep 19, 2014

facebook-github-bot commented Sep 19, 2014

facebook-github-bot commented Sep 19, 2014

brndnmtthws commented Sep 19, 2014

brndnmtthws commented Sep 20, 2014

brndnmtthws commented Sep 24, 2014

brndnmtthws commented Oct 2, 2014

victorpoluceno commented Oct 3, 2014

brndnmtthws commented Oct 7, 2014

brndnmtthws commented Oct 18, 2014

brndnmtthws commented Oct 18, 2014

brndnmtthws commented Oct 18, 2014

martint commented Oct 18, 2014

brndnmtthws commented Oct 18, 2014

csarcom commented Oct 29, 2014

brndnmtthws commented Oct 29, 2014

martint commented Oct 29, 2014