does proxygen have websockets support?

[mariasmo]

hi ,

does proxygen have websockets support yet?

thanks

[afrind]

Can you elaborate by what websocket support you would like from proxygen? Proxygen can handle the HTTP interactions required for a websocket handshake (Upgrade headers, send 101 Switching Protocls), but does not provide any native parsing or generating of websocket frames.

[jmccl]

I suspect @mariasmo is essentially requesting that the websocket proxygen module referred to by @lanxi in #170 be open sourced.

[ritunp]

We recently added support for WebSockets. Proxygen handles the handshake part if the application asks for a WebSocket upgrade. To ask for a WebSocket upgrade on a transaction, the HTTPMessage has a call "setEgressWebsocketUpgrade". Responses will similarly be marked with a flag if they contain appropriate WebSocket response headers - this can be checked with a call to "isIngressWebsocketUpgrade" on the HTTPMessage.

Note: for now, you would need to add the "Sec-WebSocket-Version" header to the HTTPMessage. This requirement should go away soon.

[frenchietechie]

Hello does anybody have an example of making a working websocket request?

I have been at this for a couple of days and I can't get it to work

[frenchietechie]

PS: trying various variations of something like this: https://gist.github.com/frenchietechie/47ba9ffa069f359ad99e1dcbf7f7f892

but I keep getting error codes such as

Bad Request

Your browser sent a request that this server could not understand.

[kvtsoy]

Are you connecting to a proxygen server?

[jbeshay]

An example has been committed in bc44e34.