Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Having the devtools extension enabled breaks Kibana #1375

Closed
ThiefMaster opened this issue Aug 15, 2019 · 3 comments
Closed

Having the devtools extension enabled breaks Kibana #1375

ThiefMaster opened this issue Aug 15, 2019 · 3 comments

Comments

@ThiefMaster
Copy link

elastic/kibana#22529

I'm pretty sure this happens because Kibana does not expect the message posted by the devtools. While I think it should be fixed in Kibana, they don't seem to are too much about that issue. Any chance something could be done on the devtools side to avoid this? Having to use an incognito window (where the extension is disabled) is quite annoying

@ngyikp
Copy link
Contributor

ngyikp commented Aug 15, 2019

If Kibana breaks when some third-party script calling postMessage (not confirmed), then wouldn't other browser extensions also cause trouble?

@ThiefMaster
Copy link
Author

If they send a message with non-string data then yes, likely... To be honest, I didn't look into its source code to see if they filter out certain messages and the one from the react devtools just gets through for some reason..

@ThiefMaster
Copy link
Author

I just tried and a simple window.postMessage({source: 'me'}, window.origin) crashes it too. So maybe it's not very common for other browser extensions to post messages? Anyway, I guess there's not much that can't be done on the devtools side... :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants