Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Design a default screen when no React instance is detected #31

Closed
sebmarkbage opened this issue Mar 18, 2014 · 5 comments
Closed

Design a default screen when no React instance is detected #31

sebmarkbage opened this issue Mar 18, 2014 · 5 comments
Assignees
Milestone

Comments

@sebmarkbage
Copy link
Contributor

Currently we don't show the React tab if we can't detect React. We should have a better default screen that explains how you can get React and how to make it work with DevTools on your page.

@kassens
Copy link
Member

kassens commented Mar 25, 2014

I like how it currently doesn't spam the devtools tab as long as you are not on a React enabled page.
I could see it useful if there are scenarios where the devtools would fail to detect React on the page.

@mrienstra
Copy link

@sebmarkbage By "default screen", do you mean a webpage that is automatically loaded into a new tab on "first run" (and possible on extension upgrade), with basic instructions on extension usage?

If so, I agree, this would be a great place to inform users about why they might not be seeing the React tab. (#28)

@sebmarkbage
Copy link
Contributor Author

It probably wouldn't be visible on first run if there already is a React instance on the page.

@mrienstra
Copy link

@sebmarkbage I was referring to something that only appears once, when the extension is installed (could also appear when the extension is updated). I think you are talking about having the "React" tab in developer tools always visible. I agree with @kassens that this would not be ideal.

https://developer.chrome.com/extensions/faq#faq-lifecycle-events
http://stackoverflow.com/questions/2399389/detect-chrome-extension-first-run-update
https://adblockplus.org/development-builds/new-first-run-page

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants