Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Can't inspect state or props #63

Closed
TomClarkson opened this issue Jan 28, 2015 · 4 comments
Closed

Can't inspect state or props #63

TomClarkson opened this issue Jan 28, 2015 · 4 comments

Comments

@TomClarkson
Copy link

See around 18.50 https://www.youtube.com/watch?v=kNVatRjnU7U . It used to expand with state and props information but does not work anymore.

@jaredly
Copy link
Contributor

jaredly commented Jan 31, 2015

It's just buggy --- sometimes it does work

@jhollingworth
Copy link

This used to work but I think it's broken in newer versions of Chrome. I've traced the bug down to an error thrown on this line but not sure what the fix is

jhollingworth added a commit to jhollingworth/react-devtools that referenced this issue Mar 10, 2015
In newer versions of Chrome you can't expand any tree element (e.g. I
can't expand/collpse the state props).

The cause was this line of code which I'm guessing is using a
depreciated API:
https://github.com/sebmarkbage/blink-devtools/blob/master/Source/devtools/front_end/treeoutline.js#L943.

I'm guessing the correct thing to do would be to update blink-devtools
to the latest however as a stop gap we can update
TreeElement.prototype.isEventWithinDisclosureTriangle with its latest
implementation:
https://chromium.googlesource.com/chromium/blink/+/master/Source/devtools/front_end/ui/treeoutline.js.
It's far from ideal but it solves the problem.

Fixes facebook#63.
@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@jaredly
Copy link
Contributor

jaredly commented Aug 5, 2015

This is fixed in the beta version we just released.
Let us know what you think!

@jaredly jaredly closed this as completed Aug 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants