Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Flow errors with npm #817

Closed
zinoviev opened this issue Jun 17, 2017 · 2 comments
Closed

Flow errors with npm #817

zinoviev opened this issue Jun 17, 2017 · 2 comments

Comments

@zinoviev
Copy link
Contributor

zinoviev commented Jun 17, 2017

The last PR builds failed with flow errors on promise package

I spot these on last two PR #569 and #677 and it's true for master as well

On my local environment, everything is fine with yarn but doesn't work with npm
Promise is fbjs dependency ^7.03, with yarn it's resolved with 7.1.1 version for npm it's 7.3.0

7.3.0 promise kills our build
then/promise#135

Not sure how to deal with it - wait for promise team for fix or pin promise version in fbjs

@zinoviev zinoviev changed the title Flow failes with npm Flow errors with npm Jun 17, 2017
@ForbesLindesay
Copy link

This should now be resolved.

@bvaughn
Copy link
Contributor

bvaughn commented Jun 20, 2017

Can confirm, CI seems happy now. Thanks for the update, @ForbesLindesay!

@bvaughn bvaughn closed this as completed Jun 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants