Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link needed in blurb about App Transport Security exception #112

Closed
carlbennettnz opened this issue Jan 2, 2018 · 6 comments
Closed

Link needed in blurb about App Transport Security exception #112

carlbennettnz opened this issue Jan 2, 2018 · 6 comments
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.

Comments

@carlbennettnz
Copy link

From the Networking page:

By default, iOS will block any request that's not encrypted using SSL. If you need to fetch from a cleartext URL (one that begins with http) you will first need to add an App Transport Security exception. If you know ahead of time what domains you will need access to, it is more secure to add exceptions just for those domains; if the domains are not known until runtime you can disable ATS completely. Note however that from January 2017, Apple's App Store review will require reasonable justification for disabling ATS. See Apple's documentation for more information.

The part about disabling it completely has a link, but how to add an exception for specific domains is not. Linking to a resource that explains how to do this would be useful, particularly for users of create-react-native-app, which seems to hide things like the info.plist file mentioned in this article that appears if you google it.

@hramos hramos added the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jan 23, 2018
@isaacsolo
Copy link
Contributor

I'll work on this.

@charpeni
Copy link
Contributor

charpeni commented Feb 3, 2018

@carlbennettnz does the PR #177 is enough?

@carlbennettnz
Copy link
Author

Hey, sorry, just saw this. Good improvement, thanks 👍

Only concern is that the Info.plist referred to in the linked resource is hidden by create-react-native-app. When I tried to create my first app, I found similar instructions, but never found this file.

@isaacsolo
Copy link
Contributor

Oh, I see what you mean. In that case, would the developer have to add React Native to a native iOS app then?

@carlbennettnz
Copy link
Author

Not sure. I gave up after getting stuck on this and went back to PWAs instead.

@divyanshu-rawat
Copy link
Contributor

@charpeni it would be great if you can close this issue as PR for the same has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.
Projects
None yet
Development

No branches or pull requests

5 participants