Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running on device page - Platform selections broken #2771

Closed
colindaly opened this issue Sep 7, 2021 · 9 comments · Fixed by #2856
Closed

Running on device page - Platform selections broken #2771

colindaly opened this issue Sep 7, 2021 · 9 comments · Fixed by #2856

Comments

@colindaly
Copy link

colindaly commented Sep 7, 2021

Running on device page

https://github.com/facebook/react-native-website/blob/main/docs/running-on-device.md
Cannot change from Android to iOS
Linux is also selected by default and cannot select Windows or Mac

Documentation version

Latest and previous versions

@Simek
Copy link
Collaborator

Simek commented Sep 7, 2021

Hi @colindaly, the tabs on the Running On Device page seem to work fine for me on macOS and Windows in Chrome and FF.

Can you provide the details about your OS and browser?

Also, did you try to refresh the local caches? (Cmd/Ctrl + Shift + R)

@GijsWeterings
Copy link
Contributor

Hi @colindaly! I can't reproduce this on my devices on https://reactnative.dev/docs/next/running-on-device .
Are you using a noscript-like browser extension perhaps? Like Simek suggested, let us know your browser details if you think this isn't specific to your device, then we can try and reproduce :)

@slorber
Copy link
Contributor

slorber commented Oct 6, 2021

@colindaly we'll need more infos about your env to debug this tag problem.

Please paste the actual page link, not the github md file link.

Can you open your console and check for errors? Maybe React didn't load/hydrate properly and you only got some static markup?

In very slow connexions/cpu devices, it may take time to hydrate unfortunately, and clicks do nothing for a few seconds.

Please try to refresh the page and see if it works better.


@Josh-Cena made a change on Tabs recently (in beta 6), but I don't see how this could be the reason: facebook/docusaurus#5442

@slorber
Copy link
Contributor

slorber commented Oct 6, 2021

Thanks, we found the cause: facebook/docusaurus#5653

@vikramvi
Copy link

vikramvi commented Oct 7, 2021

Thanks, we found the cause: facebook/docusaurus#5653

Does this as well fix auto scrolling towards top of page bug as well ? Please check detailed steps for bugs reproduction #2806

@vikramvi
Copy link

vikramvi commented Oct 7, 2021

On Mac + Chrome, selection bug is fixed but auto-scrolling bug still exists.

[Update] : Stopped working again, is CI broken ? May be it pushed buggy code again to prod ?

  1. User is in middle or bottom of screen
  2. User goes to some other window e.g. VS Code
  3. User returns back to documentation page

Actual Result:

  1. Auto scrolling happens towards top, this is really annoying

@slorber
Copy link
Contributor

slorber commented Oct 7, 2021

@vikramvi the fix is not even merged on Docusaurus yet, it will take some time for the RN website to get it deployed. Once it is deployed, this issue will be closed.

About your auto-scrolling issue (not related to tab selection), it is worth creating a dedicated issue just for this possible bug. As I can't reproduce it and it was only reported by you, please also submit a video because it's not very clear to me what the problem is exactly: I need to see it.

@Josh-Cena
Copy link

@slorber I could reproduce it: same setup as @vikramvi probably, Chrome 94 + MacOS Catalina. It's not reproduced 100% consistently, though, but at least 90%

Screen.Recording.2021-10-07.at.6.43.18.PM.mov

@slorber
Copy link
Contributor

slorber commented Oct 7, 2021

Please let's move the discussion to this separate issue: #2807

This scroll behavior is unrelated to tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants