Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Help us Kotlin-ify the React Native Website #3018

Closed
14 tasks done
cortinico opened this issue Mar 16, 2022 · 22 comments · Fixed by #3360
Closed
14 tasks done

☂️ Help us Kotlin-ify the React Native Website #3018

cortinico opened this issue Mar 16, 2022 · 22 comments · Fixed by #3360
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.

Comments

@cortinico
Copy link
Contributor

cortinico commented Mar 16, 2022

Hey all 👋
We're looking for some community support to help us convert our website, https://reactnative.dev to be more Kotlin-friendly.

A lot of the docs that you can find on the website are currently Java only. We're looking into adding snippets for both Java and Kotlin, using a tabbed view.

List of Pages to address.

Those are the pages that needs conversion:

How to migrate a page.

If you wish to convert one of the page you should:

  1. Verify that the page is not claimed yet.
  2. Comment here that you claim a page.
  3. Start working on adding Kotlin support for the page.
    1. Use this PR as inspiration: Add kotlin sample code in "Integration with an Android Fragment" documentation #2977
    2. Make sure you're testing the code you're writing (please take the chance to verify that the doc is also up to date).
    3. If the documentation is not up to date, send a separate PR fixing the inconsistencies with the doc.
    4. You Kotlin code should be formatted with ktfmt (see below).
  4. Send the PR for review. Ping @cortinico and @mdvacca for a review.

Code formatting

Please use KtFmt to format the Kotlin code snippets.

You can the web UI to reformat directly from the browser:
https://facebookincubator.github.io/ktfmt/

@cortinico cortinico added the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Mar 16, 2022
@rokkoo
Copy link
Contributor

rokkoo commented Mar 23, 2022

Hi, I would like take the docs/headless-js-android.md an try to migrate it :)

@cortinico
Copy link
Contributor Author

Hi, I would like take the docs/headless-js-android.md an try to migrate it :)

Please go ahead @rokkoo 👍 I've added you in the list.

@alanjhughes
Copy link
Contributor

I can take docs/native-modules-android.md

@cortinico
Copy link
Contributor Author

I can take docs/native-modules-android.md

Added 👍

@cortinico
Copy link
Contributor Author

Just a heads up for everyone involved in Kotlin migration, please make sure references to Java and java specific concepts in the body of the article is also adapted (in other words, converting snipptes might not be enough sometimes).

Example of what I'm referring to:

@jazibjafri
Copy link
Contributor

Hi, I would like to take on the docs/custom-webview-android.md and attempt to migrate it.

@cortinico
Copy link
Contributor Author

Hi, I would like to take on the docs/custom-webview-android.md and attempt to migrate it.

Assigned 👍

@junaidn
Copy link
Contributor

junaidn commented Apr 7, 2022

Hi, I would like to take the docs/communication-android.md and try to migrate it.

@cortinico
Copy link
Contributor Author

Hi, I would like to take the docs/communication-android.md and try to migrate it.

Assigned 👍

@RickardZrinski
Copy link
Contributor

👋 I'm giving docs/native-components-android.md a go.

@cortinico
Copy link
Contributor Author

👋 I'm giving docs/native-components-android.md a go.

Assigned

@EzequielDeOliveira
Copy link
Contributor

Hi, I would like to take " docs/_integration-with-exisiting-apps-java.md"

@cortinico
Copy link
Contributor Author

Hi, I would like to take " docs/_integration-with-exisiting-apps-java.md"

Assigned 👍

@mbharadwajfb
Copy link
Contributor

Hi, I would like to take docs/new-architecture-library-intro

@cortinico
Copy link
Contributor Author

Hi, I would like to take docs/new-architecture-library-intro

Assigned 👍

@aerrayes
Copy link
Contributor

aerrayes commented Jul 4, 2022

Hi, I would like to pick up docs/new-architecture-library-android.md

@cortinico
Copy link
Contributor Author

cortinico commented Jul 4, 2022

Hi, I would like to pick up docs/new-architecture-library-android.md

Assigned

@tusharvars
Copy link
Contributor

I would like to pick new-architecture-app-modules-android

@cortinico
Copy link
Contributor Author

I would like to pick new-architecture-app-modules-android

Assigned 👍

@dakshbhardwaj
Copy link
Contributor

Hi i would like to pick docs/new-architecture-app-renderer-android.md

@cortinico
Copy link
Contributor Author

Hi i would like to pick docs/new-architecture-app-renderer-android.md

Assigned 👍

@cortinico
Copy link
Contributor Author

Hey all,
I'm happy to share that our website is now fully bi-lingual with Kotlin & Java snippets!
Thank you all for the suppport

I'd like to personally thank @rokkoo @alanjhughes @mbharadwajfb @tusharvars @dakshbhardwaj @aerrayes @jazibjafri @junaidn @RickardZrinski @EzequielDeOliveira for their contributions here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.