Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs out of date for "Publishing to Apple App Store" #3951

Closed
rickhanlonii opened this issue Dec 11, 2023 · 4 comments · Fixed by #3953
Closed

Docs out of date for "Publishing to Apple App Store" #3951

rickhanlonii opened this issue Dec 11, 2023 · 4 comments · Fixed by #3953
Labels
Never gets stale Prevent issues/PRs from getting stale p: Facebook RN Team

Comments

@rickhanlonii
Copy link
Member

rickhanlonii commented Dec 11, 2023 •
edited by cortinico

React Native Version

0.73

Description

In facebook/react-native#37923 we changed Info.plist to add NSAllowsArbitraryLoads=false and NSAllowsLocalNetworking=true.

That means, this section of the React Native docs are now out of date:

Screenshot 2023-12-11 at 4 28 40 PM

Steps to reproduce

  1. install new project
  2. follow guide to publish to app store
  3. see inconsistency

Affected Platforms

Runtime - iOS

Output of npx react-native info

no

Stacktrace or Logs

no

Reproducer

no

Screenshots and Videos

Above
@github-actions GitHub Actions
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@rickhanlonii
Copy link
Member Author

bad bot, no

@rickhanlonii
Copy link
Member Author

cc @philIip @lunaleaps

@rickhanlonii rickhanlonii added p: Facebook RN Team Never gets stale Prevent issues/PRs from getting stale labels Dec 11, 2023
@cortinico cortinico transferred this issue from facebook/react-native Dec 12, 2023
@cortinico cortinico mentioned this issue Dec 12, 2023
Merged
@cortinico
Copy link
Contributor

Good point, I've fixed it in #3953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Never gets stale Prevent issues/PRs from getting stale p: Facebook RN Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not suggest users to 'Enable App Transport Security' facebook/react-native-website
2 participants
@rickhanlonii @cortinico