Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix homepage and environment setup docs styling #4126

Merged
merged 5 commits into from
May 27, 2024
Merged

Fix homepage and environment setup docs styling #4126

merged 5 commits into from
May 27, 2024

Conversation

jonsamp
Copy link
Contributor

@jonsamp jonsamp commented May 21, 2024 •
edited

Why

Addresses #4124.

After releasing the home page, I got a few points of feedback to address. This PR:

  • Adds dark mode colors to the "Continue with Expo" button on /docs/environment-setup. Pictured below is the hovered state:
    Screenshot 2024-05-20 at 10 02 28 PM
  • Removes large format devices when viewing the site on a more narrow page:
    • Wide page shows all of the devices in the illustration
    Screenshot 2024-05-20 at 5 03 36 PM - Narrow page shows only Android and iOS devices Screenshot 2024-05-20 at 5 03 31 PM
  • Added a new illustration for the Framework > Tools card. Previously it looked like Expo was offering tools that are provided by React Native. I updated it to show a pseudo-UI of Expo Orbit. I tried to make the image timeless (no mentions of the Pixel 8 or iPhone 15) since those will be dated quickly.
    Screenshot 2024-05-20 at 9 57 32 PM
    Screenshot 2024-05-20 at 10 02 13 PM
  • Added a more recent video to the Watch section. Now it shows the following video, which is from React Conf 2024: https://www.youtube.com/live/0ckOUBiuxVY?si=PmlrPytEh9V_gDJw&t=2315

Test plan

Look at the home page and make sure that sections mentioned above look correct. Also click on "Get started" to go to /docs/environment-setup and make sure that the "Continue with Expo" button has the correct colors in light and dark mode.

@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit e082c6f
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6654a9b6e021fe00087004ff
😎 Deploy Preview https://deploy-preview-4126--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonsamp jonsamp mentioned this pull request May 21, 2024
Closed
@jonsamp jonsamp changed the title Eng 12366 fix react native docs styling issues Fix homepage and environment setup docs styling May 21, 2024
@Simek Simek linked an issue May 21, 2024 that may be closed by this pull request
Fix hover color for "Continue with Expo" link button in dark mode #4124
Closed
Simek
Simek approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM! 👍

@Simek Simek requested a review from cortinico May 21, 2024 05:55
@jonsamp jonsamp requested review from hezi and Simek May 27, 2024 16:46
@Simek Simek merged commit 3903811 into facebook:main May 27, 2024
5 checks passed
@Simek Simek mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek approved these changes

@cortinico cortinico Awaiting requested review from cortinico

@hezi hezi Awaiting requested review from hezi

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix hover color for "Continue with Expo" link button in dark mode
4 participants
@jonsamp @hezi @Simek @facebook-github-bot