Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animated doc missing property type defs #77

Closed
hramos opened this issue Dec 18, 2017 · 2 comments
Closed

Animated doc missing property type defs #77

hramos opened this issue Dec 18, 2017 · 2 comments
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.

Comments

@hramos
Copy link
Contributor

hramos commented Dec 18, 2017

Scroll to the bottom of http://facebook.github.io/react-native/docs/animated.html - there's a few empty prop types.
@jaredly
Copy link
Contributor

jaredly commented Jun 15, 2018

srsly
image

@hramos hramos added the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jun 19, 2018
@hramos
Copy link
Contributor Author

hramos commented Jun 19, 2018 •
edited

For anyone interested in fixing this - you can look up the docblocks from the source code of Animated in the react-native repo and get the missing text there. Shouldn't be much trouble to add these back, we just missed them during the migration to plain markdown docs.

@dhwanilvyas dhwanilvyas mentioned this issue Aug 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredly @hramos