-
Notifications
You must be signed in to change notification settings - Fork 45.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trapBubbledEventsLocal #10258
Remove trapBubbledEventsLocal #10258
Conversation
Hmm. I don’t think that’s what the TODO was referring to. If I understand it right, the TODO is asking to inline the calls themselves instead of
This lets us avoid doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see above
I took that approach in #9924 but didn't get any feedback. I just resurrected that branch and merged master and some tests are failing, but I'll take a look later. I can just revert the initial commit and squash commit onto this branch to keep the conversation in one place |
It looks like it was just a local issue. Ready for review @gaearon |
Yea, sorry about that. This is our biggest release yet and we haven’t been reviewing things well. |
Looked through the code in each case and did manual testing for some of these. |
No worries, @gaearon. Y'all get a lot of PR's |
This PR moves calls to
trapBubbledEventsLocal
outside of an equivalent switch statement of html tags.This is a duplicate of #9973. I think y'all were busy cleaning up 15.6 when I first PR'ed this.