New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile spread to Object.assign calls #10387

Merged

gaearon merged 1 commit into facebook:master from gaearon:object-assign

Aug 4, 2017

Collaborator

gaearon commented Aug 4, 2017

Noticed Rollup was complaining about _extends helper repeating.

But we don’t need it. Instead let’s emit Object.assign calls.
Diff of build folder: https://gist.github.com/gaearon/50e2b020a6d7d549e2c7b0273f01016e.

FB and RN bundles now get plain Object.assign(), UMD and CJS bundles keep using the polyfill.


          Compile spread to Object.assign calls

b961d55

facebook-github-bot added the CLA Signed label

gaearon requested review from sophiebits and bvaughn

August 4, 2017 18:07

Contributor

nhunzaker commented Aug 4, 2017

👍

gaearon merged commit 145986e into facebook:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment