Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrl + Enter keypress only works in firefox #10515

Closed
nstraub opened this issue Aug 23, 2017 · 3 comments
Closed

ctrl + Enter keypress only works in firefox #10515

nstraub opened this issue Aug 23, 2017 · 3 comments
Labels
Component: DOM Type: Bug

Comments

@nstraub
Copy link
Contributor

nstraub commented Aug 23, 2017

It doesn't work in chrome, IE 11, edge nor chrome on Ubuntu. these browsers report a charCode of 10 and the event dispatcher dismisses it
I've made a pull request with an unobtrusive fix here: #10514
@nstraub nstraub mentioned this issue Aug 23, 2017
Merged
@greatbody
Copy link

have to say some thing anyway.

@nstraub
Copy link
Contributor Author

nstraub commented Nov 21, 2017

@gaearon while investigating for my PR I found this.
Apparently, it doesn't fail on macs, only windows and linux (when not running firefox)

@gaearon
Copy link
Collaborator

gaearon commented Jan 5, 2018

Fixed in #10514.

@gaearon gaearon closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DOM Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaearon @nstraub @greatbody