Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] maintain scroll position of mobile menus #10952

Closed
KyleAMathews opened this issue Sep 29, 2017 · 2 comments
Closed

[website] maintain scroll position of mobile menus #10952

KyleAMathews opened this issue Sep 29, 2017 · 2 comments

Comments

@KyleAMathews
Copy link
Contributor

When going quickly through pages on mobile, it'd be really nice if as you scroll down long menus e.g. in docs, if after navigating to the next page and then returning to the menu if the previous scroll position is maintained/restored.

This could be done by a) rendering the menu in the layout component which isnt unmounted on page changes or by storing the menu scroll position in the layout again and then passing it into the page component on render.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 30, 2017

rendering the menu in the layout component which isnt unmounted on page changes

Pages currently inject params into the nav menu.

or by storing the menu scroll position in the layout again and then passing it into the page component on render

Sounds more promising.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Thank you for filing this issue! 😄

The documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

I've moved your issue to the new repo: reactjs/react.dev#19

Let's continue the discussion there! Sorry for the inconvenience.

@bvaughn bvaughn closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants