Fix blog issues that resulted from migration #11089
Conversation
|
Deploy preview ready! Built with commit db91149 |
| @@ -80,7 +80,7 @@ some pretty cool things with it: | |||
| (including IE8) and automatically use | |||
| [event delegation](http://davidwalsh.name/event-delegate). | |||
|
|
|||
| Head on over to [facebook.github.io/react](/react) to check out what we have | |||
There was a problem hiding this comment.
This is a 404 now because it redirects to https://reactjs.org/react
| @@ -74,6 +74,6 @@ este.demos.react.todoApp = este.react.create (`/** @lends {React.ReactComponent. | |||
| > I'm the author of "[Land of Lisp](http://landoflisp.com/)" and I love your framework. I built a somewhat similar framework a year ago [WebFUI](https://github.com/drcode/webfui) aimed at ClojureScript. My framework also uses global event delegates, a global "render" function, DOM reconciliation, etc just like react.js. (Of course these ideas all have been floating around the ether for ages, always great to see more people building on them.) | |||
| > | |||
| > Your implementation is more robust, and so I think the next point release of webfui will simply delegate all the "hard work" to react.js and will only focus on the areas where it adds value (enabling purely functional UI programming in clojurescript, and some other stuff related to streamlining event handling) | |||
| <figure><a href="https://groups.google.com/forum/#!msg/reactjs/e3bYersyd64/qODfcuBR9LwJ"><img src="../img/blog/landoflisp.png"></a></figure> | |||
There was a problem hiding this comment.
Current markdown rendering engine requires this line to have a > at the start to treat the whole chunk as one single blockquote.
| @@ -30,13 +30,13 @@ React is only one-piece of your web application stack. [Mark Lussier](https://gi | |||
|
|
|||
| [Selem Delul](http://selem.im) bundled the [React Tutorial](/tutorial/tutorial.html) into a rails app. This is a good example on how to get started with a rails project. | |||
|
|
|||
| > ```sh | |||
There was a problem hiding this comment.
Current markdown rendering engine requires these lines to have a > at the start to treat the whole chunk as one single blockquote.
| @@ -33,7 +33,7 @@ We've also published version `0.13.1` of the `react` and `react-tools` packages | |||
|
|
|||
| ### React with Add-Ons | |||
|
|
|||
| ### Bug Fixes | |||
| #### Bug Fixes | |||
There was a problem hiding this comment.
The rest of the "Bug Fixes" heading in this post are ####.
| @@ -48,10 +48,6 @@ Interact with this [visual tour of Relay's architecture](http://sgwilym.github.i | |||
|
|
|||
| Sam has already launched a product that leverages Relay's data-fetching, optimistic responses, pagination, and mutations – all atop a Ruby GraphQL server: [new.comique.co](http://new.comique.co/) | |||
|
|
|||
| ## Prototyping in the browser | |||
|
|
|||
| I ([steveluscher](https://github.com/steveluscher)) whipped up [a prototyping tool](https://facebook.github.io/relay/prototyping/playground.html) that you can use to hack on a schema and a React/Relay app, from the comfort of your browser. Thanks to Jimmy Jia ([taion](https://github.com/taion)) for supplying the local-only network layer, [relay-local-schema](https://github.com/relay-tools/relay-local-schema). | |||
There was a problem hiding this comment.
According to facebook/relay#1965, Relay Playground has been removed. I think this section should be removed as well as https://facebook.github.io/relay/prototyping/playground.html leads to a 404.
| @@ -60,7 +56,7 @@ Michael Hart ([mhart](https://mhart)) built a [simple-relay-starter](https://git | |||
|
|
|||
| ## Routing around | |||
|
|
|||
| Jimmy Jia ([taion](https://github.com/taion)) and Gerald Monaco ([devknoll](https://github.com/devknoll)) have been helping lost URLs find their way to Relay apps through their work on [react-router-relay](https://github.com/relay-tools/react-router-relay). Check out Christoph Pojer's ([cpojer](https://github.com/cpojer)) [blog post](https://medium.com/@cpojer/relay-and-routing-36b5439bad9) on the topic. Jimmy completed the Relay TodoMVC example with routing, which you can check out at [taion/relay-todomvc](https://github.com/taion/relay-todomvc). | |||
| Jimmy Jia ([taion](https://github.com/taion)) and Gerald Monaco ([devknoll](https://github.com/devknoll)) have been helping lost URLs find their way to Relay apps through their work on [react-router-relay](https://github.com/relay-tools/react-router-relay). Check out Christoph Nakazawa's ([cpojer](https://github.com/cpojer)) [blog post](https://medium.com/@cpojer/relay-and-routing-36b5439bad9) on the topic. Jimmy completed the Relay TodoMVC example with routing, which you can check out at [taion/relay-todomvc](https://github.com/taion/relay-todomvc). | |||
There was a problem hiding this comment.
Christoph Pojer -> Christoph Nakazawa
| @@ -184,6 +184,7 @@ const sharedStyles = { | |||
| marginTop: 25, | |||
| marginLeft: -30, | |||
| marginRight: -30, | |||
| marginBottom: 25, | |||
There was a problem hiding this comment.
It looks better with margin between code blocks and the content below it.
Prev
Curr
| @@ -237,7 +238,7 @@ const sharedStyles = { | |||
| '& p > code, & li > code': { | |||
| background: hex2rgba(colors.note, 0.3), | |||
| padding: '0 3px', | |||
| fontSize: 16, | |||
| fontSize: 'inherit', | |||
There was a problem hiding this comment.
IMO, the font size of <code> should not be hardcoded as 16 because it is used in multiple places with different font size:
Prev
Curr
|
This is awesome. Thanks for such attention to detail. |
|
Thanks for tagging me, Dan! I've already started migrating the website to a new git repo. I'll make sure these changes make it over though. |
The new markdown rendering engine does not parse non-plaintext stuff that is within blockquotes well (very prevalent in the community roundup posts). This PR fixes those issues, along with other stuff.
I also realized the blog images are not rendering properly and an issue has already been filed at gatsbyjs/gatsby#2048. Changing the
<img src="...">tosyntax works for fixing most of those image issues. I'm not sure whether we should wait for this issue to be fixed in Gatsby or we can just change the syntax to the working version first. Let me know if the latter is preferred and I can submit a PR for that.