Use indexOf instead of includes in RangeKeyboardFixture #11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the DOM Fixture change test case to work in older browsers.
nhunzaker
commented
Oct 6, 2017
| if (![37, 38, 39, 40].includes(e.keyCode)) return; | ||
| if ([37, 38, 39, 40].indexOf(e.keyCode) < 0) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
The linter was fussing at me about no curlies after the if, so I threw em in.
|
Deploy preview ready! Built with commit f322b5c |
jquense
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older browsers don't have
[].includes. I thought about adding the polyfill, but indexOf is simple enough.This allows us to test the range input change event test fixture in IE10-11 and older Chrome/Safari/Firefox.
Fixes #11132