Remove priority coalescing and PriorityLevel module #11187
Conversation
| @@ -1518,58 +1482,51 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>( | |||
| } | |||
| } | |||
|
|
|||
| function getPriorityContext( | |||
| function getExpirationTime( | |||
There was a problem hiding this comment.
This needs a better name. I was really confused what this does.
getExpirationTimeForUpdatesOn(...)?
I don't know...
There was a problem hiding this comment.
Agree it's confusing. Working on a PR that will remove this function entirely, so I'll leave it for now.
Coalescing is the only feature that depends on PriorityLevel. Since we're not sure if coalescing is even valuable, we'll remove it for now. If it turns out we need it, we can add it back later.
acdlite
force-pushed
the
removepriority
branch
from
3e36db5
to
9ba4503
Compare
|
Could I ask that what's the difference between coalescing and batch updates except the interval between those updates? And if "Since we're not sure if coalescing is even valuable", why you write theses codes before, what's your thoughts before? |
| } else { | ||
| // Updates during the render phase should expire at the same time as | ||
| // the work that is being rendered. | ||
| expirationTime = nextRenderExpirationTime; |
There was a problem hiding this comment.
From the comment 'Updates during the render phase', I'm a little confused why we use else rather than else if (isRendering) here, @acdlite would you mind explain some details? Thanks!
Coalescing is the only feature that depends on PriorityLevel. Since we're not sure if coalescing is even valuable, we'll remove it for now. If it turns out we need it, we can add it back later.