commoner's grep for @providesModule turns up vim swap files #111
Assignees
Comments
|
@benjamn Should we fix this in commoner? |
|
Oh, interesting. I dealt with a related problem with Emacs Definitely a thing that Commoner should handle intelligently. |
ghost
assigned
|
What if the tie was broken according to the length of the filename (shortest wins)? Is that too much of a hack? |
|
What do other things (like |
|
@zpao good call; turns out CoffeeScript doesn't try to be super clever about this: https://github.com/jashkenas/coffee-script/blob/8e90aaefc1/lib/coffee-script/command.js#L33-L35 |
|
Fixed in Commoner 0.8.1: https://github.com/benjamn/commoner/issues/31 |
taneliang
referenced
this issue
in MLH-Fellowship/react
Aug 17, 2020
Summary --- Resolves #44. Intended to highlight all related React events. However, it looks like separate promises can have the same wakeable ID, which is a bit strange. TODO --- * Ensure that we are correctly understanding wakeable IDs, i.e. that a unique resource/promise is a unique wakeable. * Check if `unstable_createResource` caches promises. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code
taneliang
referenced
this issue
in MLH-Fellowship/react
Aug 19, 2020
Summary --- Resolves #44. Intended to highlight all related React events. However, it looks like separate promises can have the same wakeable ID, which is a bit strange. TODO --- * Ensure that we are correctly understanding wakeable IDs, i.e. that a unique resource/promise is a unique wakeable. * Check if `unstable_createResource` caches promises. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was getting errors from grunt because of this and maybe this was also causing some confusion of mine before. Not sure what the right thing to do here, but perhaps it should filter by file extension (and hidden-ness? my vim swap filenames start with
..)The text was updated successfully, but these errors were encountered: