Removed useless typechecking #11323
Merged
Removed useless typechecking #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e have`t flow comment
|
Yes. We are in a good place now to start increasing Flow coverage. So if you'd like to raise an issue discussing the strategy that would be great. |
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
…e have`t flow comment (facebook#11323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gaearon After our dialog (https://github.com/facebook/react/pull/10227/files#r146112953) I delete this useless typechecking. I tried to add a flow to the file, but flow found 23 errors. I think I can fix these errors later, but I need help with types. Some files and functions in package React don't have typings. I can add any type, but this is a bad practice.
Do you have a plan to add flow typechecking for all files in React package or not?
If you have, we can talk about it and gradually add typing for all files.