Fix React.createFactory() crash #11484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemmy
approved these changes
Nov 7, 2017
|
LGTM after prettier failure is addressed. |
gaearon
commented
Nov 7, 2017
packages/react/src/ReactElement.js
Outdated
| @@ -237,10 +237,9 @@ export function createElement(type, config, children) { | |||
| typeof props.$$typeof === 'undefined' || | |||
| props.$$typeof !== REACT_ELEMENT_TYPE | |||
| ) { | |||
| var displayName = | |||
There was a problem hiding this comment.
Isn't this weird though? I don't think I touched this code but now it wants me to reformat it.
nhunzaker
approved these changes
Nov 7, 2017
| it('should support React public API methods', () => { | ||
| expect(React.isValidElement(42)).toBe(false); | ||
| expect(React.isValidElement(<div />)).toBe(true); | ||
| expect(React.cloneElement(<div />, {foo: 42})).toEqual(<div foo={42} />); |
There was a problem hiding this comment.
Huh. Cool that loose equality works out this way!
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Add a failing test for createFactory in production * Fix createFactory() in production * Add more prod-only tests * Fix prettier * Run prettier 1.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. Standalone fix for this is being committed to www.