Replace ReactFiberErrorLogger injection with static forks #11717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
no-fiber-dialog
branch
2 times, most recently
from
c74f314
to
cf9f0be
Compare
gaearon
force-pushed
the
no-fiber-dialog
branch
from
cf9f0be
to
4850246
Compare
bvaughn
approved these changes
Nov 30, 2017
gaearon
force-pushed
the
no-fiber-dialog
branch
from
4850246
to
0466f15
Compare
gaearon
force-pushed
the
no-fiber-dialog
branch
from
0466f15
to
13dcc28
Compare
This was referenced Dec 30, 2023
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new static module injection system formalized in #11711 to remove the dynamic injection from one of the modules. It won't require changes on RN side, but will on www (I'll send a diff once this is merged).