Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need to stringify attributes before assigning them? #11735

Closed
nhunzaker opened this issue Dec 1, 2017 · 3 comments
Closed

Do we still need to stringify attributes before assigning them? #11735

nhunzaker opened this issue Dec 1, 2017 · 3 comments
Labels
Component: DOM Resolution: Stale Automatically closed due to inactivity Type: Enhancement

Comments

@nhunzaker
Copy link
Contributor

React manually stringifies all attributes before assigning them:

https://github.com/facebook/react/blob/master/packages/react-dom/src/client/DOMPropertyOperations.js#L169-L179

This appears to be for IE8/9. However it's possible that this is an IE8 only behavior. See IE9:

screen shot 2017-11-30 at 8 02 51 pm

screen shot 2017-11-30 at 8 03 38 pm

Can we get rid of '' + value in DOMPropertyOperations?

@syranide
Copy link
Contributor

syranide commented Dec 1, 2017

I wouldn't trust compatibility mode too much, maybe old FF has this problem too (if we still support it)?

@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 19, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: DOM Resolution: Stale Automatically closed due to inactivity Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants