Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need to check for Opera in BeforeInputPlugin? #11886

Closed
nhunzaker opened this issue Dec 19, 2017 · 3 comments
Closed

Do we still need to check for Opera in BeforeInputPlugin? #11886

nhunzaker opened this issue Dec 19, 2017 · 3 comments

Comments

@nhunzaker
Copy link
Contributor

This came up in #11854. We have a specific browser check for Opera, but Opera has used Blink for a while.

Is a version of Opera that uses Presto still in our browser support matrix? Could we remove this check?

We don't have an "official" (as official as it can be) guideline for Opera in #9301 (comment).

@sophiebits Any thoughts here? How far back does Facebook go on Opera?

@skiritsis
Copy link
Contributor

skiritsis commented Dec 19, 2017

I could remove the checks for Presto and verify that it works as expected with the latest Opera version(or is there a list of supported versions?). Considering Opera 12(which included the 'TextEvent' in window) was first released in 2012 I believe it is safe to remove it. Unless of course there is another benefit of still using the 'TextEvent' event.

@sophiebits
Copy link
Collaborator

Fine to remove as long as you can verify it doesn't affect Opera Mini. I don't anticipate bugs in current Opera that don't also exist in current Chrome so let's make a decision on those as a one-off if they ever come up.

@nhunzaker
Copy link
Contributor Author

Closed by #11921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants