Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 2 workers for all tests on CI #11990

Merged
merged 1 commit into from Jan 10, 2018
Merged

Use 2 workers for all tests on CI #11990

merged 1 commit into from Jan 10, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 8, 2018

Since #11983 worked I'm curious if it's better to always use two workers? Maybe CI will finish faster.

nhunzaker
nhunzaker approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. This is the default we use for Jest at my work.

@gaearon gaearon merged commit 4501996 into master Jan 10, 2018
@gaearon gaearon deleted the gaearon-patch-2 branch January 10, 2018 23:54
ManasJayanth pushed a commit to ManasJayanth/react that referenced this pull request Jan 12, 2018
@gaearon @ManasJayanth
Use 2 workers for all tests on CI (facebook#11990)
32a12af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhunzaker nhunzaker nhunzaker approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaearon @nhunzaker @facebook-github-bot