Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process.CI typo #12146

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Fix process.CI typo #12146

merged 1 commit into from
Feb 4, 2018

Conversation

istarkov
Copy link
Contributor

@istarkov istarkov commented Feb 3, 2018

Closes #12145

@gaearon
Copy link
Collaborator

gaearon commented Feb 3, 2018

Do we have a check like this anywhere else?

@istarkov
Copy link
Contributor Author

istarkov commented Feb 3, 2018

No, from what I see, just similar check on process.env.CI_PULL_REQUEST
which is not same as CI

CI_PULL_REQUEST

If this build is part of only one pull request, its URL will be populated here. If there was more than one pull request, it will contain one of the pull request URLs (picked randomly)

There are also check here

const isCI = !!process.env.TRAVIS_REPO_SLUG;

seems like will not work at CI at all

@istarkov
Copy link
Contributor Author

istarkov commented Feb 3, 2018

Seems like tests fail is circle cache or similar issue.

@gaearon gaearon merged commit be85544 into facebook:master Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants