Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix private API fields on the context object #12203

Closed
gaearon opened this issue Feb 10, 2018 · 1 comment
Closed

Prefix private API fields on the context object #12203

gaearon opened this issue Feb 10, 2018 · 1 comment
Assignees
@acdlite

Comments

@gaearon
Copy link
Collaborator

gaearon commented Feb 10, 2018

Which of these are safe to read?
It's not obvious to me.

screen shot 2018-02-10 at 13 43 00

Even if we don't document the others, people will think they're all safe. We should prefix unsafe ones with underscores (or even longer prefixes like __internal).
@acdlite acdlite mentioned this issue Feb 10, 2018
Closed
28 tasks
@acdlite acdlite mentioned this issue Mar 12, 2018
Merged
@aweary
Copy link
Contributor

aweary commented Mar 27, 2018

Done in #12358

@aweary aweary closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acdlite acdlite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaearon @acdlite @aweary