Ignore RN events on unknown nodes #12264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @fkgozali |
bvaughn
approved these changes
Feb 21, 2018
| @@ -31,6 +31,9 @@ const ReactNativeBridgeEventPlugin = { | |||
| nativeEvent: AnyNativeEvent, | |||
| nativeEventTarget: Object, | |||
| ): ?Object { | |||
| if (targetInst == null) { | |||
There was a problem hiding this comment.
This could use an inline comment about the case it's intended to handle. I'm not really familiar with this particular code, but it would not be obvious to me at a glance why it was okay to silently ignore this case.
sebmarkbage
approved these changes
Feb 21, 2018
If we have multiple RN renderers running simultaneously, we should be able to send a single event to all of them and only if it recognizes the event will it do anything with it. Crucially, this avoids the 'Unsupported top level event type "%s" dispatched' invariant in those cases.
sophiebits
force-pushed
the
rn-double
branch
from
c601e30
to
73837f1
Compare
LeonYuAng3NT
pushed a commit
to LeonYuAng3NT/react
that referenced
this pull request
Mar 22, 2018
If we have multiple RN renderers running simultaneously, we should be able to send a single event to all of them and only if it recognizes the event will it do anything with it. Crucially, this avoids the 'Unsupported top level event type "%s" dispatched' invariant in those cases.
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
If we have multiple RN renderers running simultaneously, we should be able to send a single event to all of them and only if it recognizes the event will it do anything with it. Crucially, this avoids the 'Unsupported top level event type "%s" dispatched' invariant in those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have multiple RN renderers running simultaneously, we should be able to send a single event to all of them and only if it recognizes the event will it do anything with it. Crucially, this avoids the 'Unsupported top level event type "%s" dispatched' invariant in those cases.