[RN] Remove unstable_batchedUpdates and unmountComponentAtNodeAndRemoveContainer from Fabric #12571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veContainer from Fabric These don't make much sense in Fabric, since Fabric will be async by default only. And unmount+remove container is a sketchy API we should remove so we might as well make sure modern containers enforce that.
sebmarkbage
commented
Apr 8, 2018
| @@ -75,8 +71,6 @@ const ReactFabric: ReactNativeType = { | |||
| return ReactPortal.createPortal(children, containerTag, null, key); | |||
| }, | |||
|
|
|||
| unstable_batchedUpdates: ReactGenericBatching.batchedUpdates, | |||
There was a problem hiding this comment.
If we at some point switch this to be the only ReactNative export, then we might need to add a noop with a warning here just for legacy purposes.
|
@fkgozali We'll need to update the call in Surface to use unmountComponentAtNode instead. Although long term we need a better solution for async unmounting. |
acdlite
approved these changes
Apr 10, 2018
This was referenced Apr 17, 2018
This was referenced Apr 19, 2018
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…veContainer from Fabric (facebook#12571) These don't make much sense in Fabric, since Fabric will be async by default only. And unmount+remove container is a sketchy API we should remove so we might as well make sure modern containers enforce that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't make much sense in Fabric, since Fabric will be async by default only.
And unmount+remove container is a sketchy API we should remove so we might as well make sure modern containers enforce that. It's not functional in Fabric anyway.