Mark context consumers with PerformedWork effect on render #12729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this has some overhead and ForwardRef is likely going to be used around context, let's skip it. We don't highlight ForwardRef alone in DevTools anyway.
gaearon
changed the title
bvaughn
approved these changes
May 2, 2018
|
It's adding overhead but I'm not highlighting their updates in DevTools anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's used by DevTools for "Highlight Updates" feature.
We already mark both classes and functions with it.
It was only used for classes by DevTools, which treated context consumers as always changing. But that turned out to be subtly wrong in some cases (see #12715).