Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Received true for a non-boolean attribute someProp #12741

Closed
jpggvilaca opened this issue May 4, 2018 · 2 comments
Closed

Warning: Received true for a non-boolean attribute someProp #12741

jpggvilaca opened this issue May 4, 2018 · 2 comments

Comments

@jpggvilaca
Copy link

Do you want to request a feature or report a bug?
Report

What is the current behavior?
When I pass a boolean prop, say:

<SomeComponent enable /> I get this warning for the enable prop, this wasn't happening in React 15.x. Do I need to use prop="true" or prop={true} ? why?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

What is the expected behavior?
Not getting this warning

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 16.3.2 | Google Chrome

@gaearon
Copy link
Collaborator

gaearon commented May 4, 2018

You’ll only get this warning if SomeComponent itself passes all its props (including the boolean one) to the DOM element like a div. Fix it to stop passing the props that aren’t real DOM props, and the problem will be solved. It’s hard to say more without a running code example.

@gaearon gaearon closed this as completed May 4, 2018
@jpggvilaca
Copy link
Author

That's exactly what's happening. I was passing {...this.props} to a DOM element to make it as flexible as possible. Problem solved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants