Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timeout export on React object unless enableSuspense flag #12833

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 16, 2018

React includes the Timeout component type if the enableSuspense feature flag is on:

if (enableSuspense) {
  React.Timeout = REACT_TIMEOUT_TYPE;
}

But it also unconditionally includes it a few lines above:

{
  // ...
  Timeout: REACT_TIMEOUT_TYPE,
  // ...
}

One of these is a mistake? I'm guessing it's the one I deleted.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@acdlite
Copy link
Collaborator

acdlite commented May 16, 2018

Lol what doofus made that mistake?

@bvaughn
Copy link
Contributor Author

bvaughn commented May 16, 2018

I believe his name is Drewfus

@bvaughn bvaughn merged commit d6f304e into facebook:master May 16, 2018
@bvaughn bvaughn deleted the remove-unconditional-timeout-export branch May 16, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants