Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add siblings Timeout components test case #12862

Merged
merged 1 commit into from
May 22, 2018
Merged

Add siblings Timeout components test case #12862

merged 1 commit into from
May 22, 2018

Conversation

cyan33
Copy link
Contributor

@cyan33 cyan33 commented May 18, 2018

Add a test case in suspense tests where two sibling timeout components should fallback to placeholder and later recover to normal view independently.

Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cyan33 cyan33 merged commit c601f7a into facebook:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants