add functional components warning about legacy context api #12892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
May 23, 2018
| @@ -600,6 +601,11 @@ function mountIndeterminateComponent( | |||
| didWarnAboutBadClass[componentName] = true; | |||
| } | |||
| } | |||
|
|
|||
| if (workInProgress.mode & StrictMode) { | |||
| ReactStrictModeWarnings.recordLegacyContextWarning(workInProgress); | |||
There was a problem hiding this comment.
I'd expect Flow to error on this because we pass different number of arguments. Let's explicitly pass null when we don't have an instance?
There was a problem hiding this comment.
It didn't error on this, but I certainly agree on yours.
| fiber.type.contextTypes != null || | ||
| fiber.type.childContextTypes != null | ||
| fiber.type.childContextTypes != null || | ||
| (instance && typeof instance.getChildContext === 'function') |
There was a problem hiding this comment.
We try to avoid checks like something && in terms of explicit something !== null && when that argument is coming from our own code (and we know it's either null or an object).
| @@ -864,7 +877,8 @@ describe('ReactStrictMode', () => { | |||
| 'Warning: Legacy context API has been detected within a strict-mode tree: ' + | |||
| '\n in div (at **)' + | |||
| '\n in Root (at **)' + | |||
| '\n\nPlease update the following components: LegacyContextConsumer, LegacyContextProvider' + | |||
| '\n\nPlease update the following components: ' + | |||
| 'FunctionalLegacyContextConsumer, LegacyContextConsumer, LegacyContextProvider' + | |||
| '\n\nLearn more about this warning here:' + | |||
There was a problem hiding this comment.
Can you also add a test for factory component please?
gaearon
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is mentioned by @gaearon in the previous PR, functional components should also be warned if they have
contextTypes. Previously it only warns in class components.To reduce extraneous check, the logic is put into
mountIndeterminateComponent.