Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer expose ReactNativeComponentTree #12904

Merged
merged 1 commit into from
May 26, 2018

Conversation

sebmarkbage
Copy link
Collaborator

Thanks to @sophiebits we no longer use this in ScrollResponder.

Thanks to @sophiebits we no longer use this in ScrollResponder.
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @sophiebits

@bvaughn bvaughn merged commit e7bd3d5 into facebook:master May 26, 2018
@maieonbrix
Copy link

Hello,

First of all : I am sorry to disturb you by this notification
Second of all : thank you for your great work

I wanted to ask something, the exposition of the ReactNativeComponentTree allowed to find a 'node' with a node id (nativeEvent.target,...), this was the solution for some stackoverflow post.
I was wondering if there is / will be a solution to do so in the master branch some day ?

Thank you for your time

@sophiebits
Copy link
Collaborator

@maieonbrix This isn't supported. If you want to know what component was clicked, you can use an approach similar to this: https://reactjs.org/docs/handling-events.html#passing-arguments-to-event-handlers.

@maieonbrix
Copy link

I was trying to avoid this approach because I read that this is better to avoid arrow functions inside render method to avoid some problematic behaviour inside sCUpdate or when using Pure Components but I am still learning, there is a lots of sources to learn from, thank you a lot @sophiebits for your time and link :)

Have a great day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants