Record "actual" times for all Fibers within a Profiler tree (alt) #12910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 25, 2018 09:48
A global 'batch id' is updated during the commit phase. Each (profiled) Fiber has a local batch id. When the Profiler timer is started- the local id is compared to the global one in order to determine whether to reset or accumulate duration. This has the downside of adding an additional field to fibers (for profiling builds only) but the upside of containing the writes to 'render' phase and allowing the DevTools commit hook to run before durations have been cleared out (so it can read them for profiling mode).
This change gives up on accumulating time across renders of different priority, but in exchange- simplifies how the commit phase (reset) code works, and perhaps also makes the profiling code more compatible with future resuming behavior
acdlite
approved these changes
May 25, 2018
| // This prevents time from endlessly accumulating in new commits. | ||
| workInProgress.actualDuration = 0; | ||
| workInProgress.actualStartTime = 0; | ||
|
|
There was a problem hiding this comment.
These can be moved to the else block above. For the initial clone, these are already 0.
There was a problem hiding this comment.
True, although I'll have to break this up so that selfBaseTime and treeBaseTime get copied in both cases. No problem though!
4 tasks
Details of bundled changes.Comparing: 76e0707...edc7a5d react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate implementation of PR #12891
Trades the ability to accumulate "actual" time across renders of different priorities in exchange for simplifying how/when we need to reset times. Theoretically, this approach is also more compatible with future resuming behavior.