Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comment in computeAsyncExpiration() to reflect code #12994

Merged
merged 1 commit into from
Jun 7, 2018
Merged

update comment in computeAsyncExpiration() to reflect code #12994

merged 1 commit into from
Jun 7, 2018

Conversation

nateq314
Copy link
Contributor

@nateq314 nateq314 commented Jun 7, 2018

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  6. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  7. Format your code with prettier (yarn prettier).
  8. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  9. Run the Flow typechecks (yarn flow).
  10. If you haven't already, complete the CLA.

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html

@gaearon gaearon merged commit 9cf3733 into facebook:master Jun 7, 2018
@NE-SmallTown
Copy link
Contributor

I notice this 2 months ago and feel confused, I think it's intended so I don't submit a PR to fix it. LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants