Set current fiber during before-mutation traversal #13219
Conversation
| const effectTag = nextEffect.effectTag; | ||
| if (__DEV__) { | ||
| ReactCurrentFiber.setCurrentFiber(nextEffect); | ||
| } |
There was a problem hiding this comment.
Did you mean to put this inside of the while loop? I assume you meant to put it before?
There was a problem hiding this comment.
No, I meant to put it outside (just like we do in other effect traversal). It doesn't really give us anything to reset it on every iteration if we're going to set it again at the very beginning of every iteration.
There was a problem hiding this comment.
Actually sorry, I misunderstood your question (I thought you meant a different line).
But here, too, it was intentional, to match what we do in the other effect traversal. I put it inside the loop because I want to set the current fiber to the current effect as we iterate through effects. Putting it outside would defeat the purpose. Each effect is a different fiber.
There was a problem hiding this comment.
D'oh yeah, I must have misread this previously.
This sets current fiber during the
getSnapshottraversal in the commit phase.It's not currently observable because we don't have any warnings with stacks during that phase. But if we did, the stack would end up empty. With this change, we'd get the correct stack.
Verified this by changing a stack-less warning that occurs in this phase to have a stack (I didn't commit it though because I'm not sure we'd want a stack there).
The purpose of this PR isn't to fix anything, but to avoid future confusion in case we do add warnings with stacks during that phase. As far as I'm aware this was the only point in reconciliation where the stack is currently missing.