Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kepp calling peformWork consistent #13596

Merged
merged 1 commit into from Sep 18, 2018

Conversation

NE-SmallTown
Copy link
Contributor

@NE-SmallTown NE-SmallTown commented Sep 8, 2018

Because we use performSyncWork to process the Sync work, so we can just replace it here like others do

@pull-bot
Copy link

pull-bot commented Sep 8, 2018

Details of bundled changes.

Comparing: b87aabd...c51f1d6

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@NE-SmallTown
Copy link
Contributor Author

@gaearon Any update on this or I miss something?

@nhunzaker
Copy link
Contributor

@NE-SmallTown Could you update the description of this PR to explain the change? I'd like to know the context for the change.

@NE-SmallTown
Copy link
Contributor Author

@nhunzaker Sure, updated the description

@nhunzaker
Copy link
Contributor

Okay, I understand now. performSyncWork is just an alias for performWork(Sync, null); . Thanks!

@nhunzaker
Copy link
Contributor

Also, I apologize for the delay. My time to process PRs is limited. I definitely have your PRs in the queue, I just want to make sure I understand what I'm merging and sometimes that takes time.

@nhunzaker nhunzaker merged commit dd91205 into facebook:master Sep 18, 2018
@NE-SmallTown
Copy link
Contributor Author

Thanks! Don't worry, ensure the master usable is the most important thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants