Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify comment #13684

Merged
merged 2 commits into from Sep 19, 2018
Merged

Clarify comment #13684

merged 2 commits into from Sep 19, 2018

Conversation

NE-SmallTown
Copy link
Contributor

If we get lower than that,

IMO, the that refer to the '120hz' rather than the 8, so I think use 'higher' here would be better.

@NE-SmallTown NE-SmallTown mentioned this pull request Sep 19, 2018
Closed
@sizebot
Copy link

sizebot commented Sep 19, 2018 •
edited

Details of bundled changes.

Comparing: eeb8177...14ff9d6

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD
scheduler.development.js +0.1% +0.3% 13.84 KB 13.86 KB 4.24 KB 4.25 KB NODE_DEV
Scheduler-dev.js +0.1% +0.3% 14.02 KB 14.04 KB 4.27 KB 4.28 KB FB_WWW_DEV

Generated by 🚫 dangerJS

@klamping klamping mentioned this pull request Sep 19, 2018
Open
@gaearon gaearon changed the title fix typo Clarify comment Sep 19, 2018
@gaearon gaearon merged commit 518812e into facebook:master Sep 19, 2018
acdlite pushed a commit to plievone/react that referenced this pull request Oct 5, 2018
@NE-SmallTown @acdlite
Clarify comment (facebook#13684)
9ea0627 
* fix comment typo

* Update Scheduler.js
Simek pushed a commit to Simek/react that referenced this pull request Oct 25, 2018
@NE-SmallTown @Simek
Clarify comment (facebook#13684)
2963133 
* fix comment typo

* Update Scheduler.js
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@NE-SmallTown @jetoneza
Clarify comment (facebook#13684)
d3ad125 
* fix comment typo

* Update Scheduler.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowinauyeunghk01 kowinauyeunghk01 kowinauyeunghk01 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NE-SmallTown @sizebot @kowinauyeunghk01 @gaearon @facebook-github-bot