Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology: Functional -> Function Component #13775

Merged
merged 2 commits into from Oct 4, 2018
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 4, 2018

Same as reactjs/react.dev#863.
Sema doesn't mind.

Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, whatever

@sizebot
Copy link

sizebot commented Oct 4, 2018

Details of bundled changes.

Comparing: acc7f40...c595733

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 4, 2018

Maybe also drop "stateless" in warnings? It's clunky, doesn't make the warning clearer, and promotes the SFC abbreviation which sounds super complicated as official. Everybody else calls this a "function".

@acdlite
Copy link
Collaborator

acdlite commented Oct 4, 2018

Yes plz

@gaearon gaearon merged commit 40a521a into facebook:master Oct 4, 2018
acdlite pushed a commit to plievone/react that referenced this pull request Oct 5, 2018
* Terminology: Functional -> Function Component

* Drop the "stateless" (functions are already stateless, right?)
linjiajian999 pushed a commit to linjiajian999/react that referenced this pull request Oct 22, 2018
* Terminology: Functional -> Function Component

* Drop the "stateless" (functions are already stateless, right?)
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
* Terminology: Functional -> Function Component

* Drop the "stateless" (functions are already stateless, right?)
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
* Terminology: Functional -> Function Component

* Drop the "stateless" (functions are already stateless, right?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants