Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all tests running? #138

Closed
zpao opened this issue Jun 29, 2013 · 2 comments · Fixed by #144
Closed

Not all tests running? #138

zpao opened this issue Jun 29, 2013 · 2 comments · Fixed by #144
Assignees
@benjamn

Comments

@zpao
Copy link
Member

zpao commented Jun 29, 2013

https://travis-ci.org/facebook/react/builds/8558655 shows

359 spec 2171 expect 0 skip 0 fail

running tests locally...

285 spec 1536 expect 0 skip 0 fail

I looked back over the past few days and I see it happening there so it's not a strictly new problem.

Any idea what's up @benjamn?
@ghost ghost assigned benjamn Jun 29, 2013
@benjamn
Copy link
Contributor

benjamn commented Jul 1, 2013

Looking into this. First clue: grunt jsx:test seems to be compiling more files in Travis than it does locally.

@benjamn
Copy link
Contributor

benjamn commented Jul 1, 2013

Opened a Commoner issue that should address this, among other problems: https://github.com/benjamn/commoner/issues/30

benjamn added a commit to benjamn/react that referenced this issue Jul 1, 2013
@benjamn
Bump Commoner version to fix EMFILE errors.
e748be3 
Finally found a more robust solution for the "too many open files"
problem: benjamn/commoner@ad72ba42db.

Closes facebook#137.
Closes facebook#138.
@benjamn benjamn mentioned this issue Jul 1, 2013
Merged
@zpao zpao closed this as completed in #144 Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Commoner version to fix EMFILE errors benjamn/react
2 participants
@benjamn @zpao